fixed codeblocks layout with long code #4235
Conversation
|
[V1] Deploy preview failure Built without sensitive environment variables with commit 1bf1966 https://app.netlify.com/sites/docusaurus-1/deploys/602d11146fc84400082e93e1 |
|
Size Change: +14 B (0%) Total Size: 158 kB ℹ️ View Unchanged
|
|
Deploy preview for docusaurus-2 ready! Built without sensitive environment variables with commit 1bf1966 |
|
⚡️ Lighthouse report for the changes in this PR:
Lighthouse ran on https://deploy-preview-4235--docusaurus-2.netlify.app/classic/ |
rahgurung
force-pushed
the
codeblock-ui-fix
branch
from
f7e1539
to
1bf1966
Compare
|
This seems to work on https://deploy-preview-4235--docusaurus-2.netlify.app/classic/docs/2.0.0-alpha.69/markdown-features/ However, can you explain the solution? It's not clear to me why it does work, and if it's a good solution or not |
|
Unfortunately, this is not easy to fix. At the moment this PR will break line highlighting in scrollable code blocks.
|
Motivation
Fixes #3870
I found a workaround to fix the layout issue. First of all, the issue was coming in case of code with long code only. I tried fixing the width to 1px and adding the style to the parent element for fixing the dark/light mode and it fixed the issue.
Have you read the Contributing Guidelines on pull requests?
Yes
Test Plan
It works for manually for all the pages which were broken otherwise for all versions like:
https://v2.docusaurus.io/docs/2.0.0-alpha.69/markdown-features/
https://v2.docusaurus.io/docs/next/markdown-features/react